Adds a check for assigned target not being null when creating an asset #16675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR Summary
|
|
Are we sure that's the behavior we want? Also, I don't think that directly addresses the rollbar, which was triggered on the line before. It's the 
|
|
whoops i misread the rollbar.. working on it! |
|
Alright quickdraw :D
Man, really dating myself here. |
|
I feel like the bigger question here is why would that target be null? |
Godmartinz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
$targetcheck when assigning during creating an asset. It will now redirect backReturns a message of
The assigned user could not be found.also a similar error message for assigned asset and locations